Skip to content

seL4: Add new compilation targets#368

Closed
heshamelmatary wants to merge 2 commits intomainfrom
sel4
Closed

seL4: Add new compilation targets#368
heshamelmatary wants to merge 2 commits intomainfrom
sel4

Conversation

@heshamelmatary
Copy link
Copy Markdown
Member

No description provided.

Comment thread pycheribuild/config/compilation_targets.py Outdated
Comment thread pycheribuild/config/compilation_targets.py Outdated
Comment thread pycheribuild/config/compilation_targets.py Outdated
Comment thread pycheribuild/config/compilation_targets.py Outdated
Comment thread pycheribuild/config/compilation_targets.py Outdated
Copy link
Copy Markdown
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the issues I've pointed out have been fixed.

Mainly to get binutils symlinked as expected by the seL4's
cmake build system.
@arichardson
Copy link
Copy Markdown
Member

CI failure looks unrelated. Change looks good to me now, although you aren't actually using it yet.

Copy link
Copy Markdown
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you use BaremetalFreestandingTargetInfo for sel4?

@heshamelmatary
Copy link
Copy Markdown
Member Author

heshamelmatary commented Jul 24, 2023

CI failure looks unrelated. Change looks good to me now, although you aren't actually using it yet.

You can actually build compiler-rt-builtins-sel4-morello-aarch64 and compiler-rt-builtins-sel4-riscv64 with this PR. Also if you add -d it will install "-none--" tools symlinks required for building seL4. But there's still no seL4 target build yet, that I may add in the future.

@arichardson
Copy link
Copy Markdown
Member

CI failure looks unrelated. Change looks good to me now, although you aren't actually using it yet.

You can actually build compiler-rt-builtins-sel4-morello-aarch64 and compiler-rt-builtins-sel4-riscv64 with this PR. Also if you add -d it will install "-none--" tools symlinks required for building seL4. But there's still no seL4 target build yet, that I may add in the future.

True, but couldn't you use the generic baremetal compiler-rt target already? Adding the symlinks should also be possible without the new target info

@heshamelmatary
Copy link
Copy Markdown
Member Author

CI failure looks unrelated. Change looks good to me now, although you aren't actually using it yet.

You can actually build compiler-rt-builtins-sel4-morello-aarch64 and compiler-rt-builtins-sel4-riscv64 with this PR. Also if you add -d it will install "-none--" tools symlinks required for building seL4. But there's still no seL4 target build yet, that I may add in the future.

True, but couldn't you use the generic baremetal compiler-rt target already? Adding the symlinks should also be possible without the new target info

Yeah I could just use baremetal. But some variants may need different flags (e.g., hard-float vs soft-float which is the default for bare metal?) or extensions as well. I am happy to wait for this PR until I decide if it's a good idea to build seL4 projects for cheribuild or not.

@arichardson arichardson marked this pull request as draft July 26, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants