Conversation
aaf0ae0 to
a94b2fc
Compare
arichardson
left a comment
There was a problem hiding this comment.
LGTM once the issues I've pointed out have been fixed.
Mainly to get binutils symlinked as expected by the seL4's cmake build system.
|
CI failure looks unrelated. Change looks good to me now, although you aren't actually using it yet. |
arichardson
left a comment
There was a problem hiding this comment.
Actually, can you use BaremetalFreestandingTargetInfo for sel4?
You can actually build |
True, but couldn't you use the generic baremetal compiler-rt target already? Adding the symlinks should also be possible without the new target info |
Yeah I could just use baremetal. But some variants may need different flags (e.g., hard-float vs soft-float which is the default for bare metal?) or extensions as well. I am happy to wait for this PR until I decide if it's a good idea to build seL4 projects for cheribuild or not. |
No description provided.